fix(friendlist): handle legacy pbs in friendlist frontend (show less details) (@wradion) #7296
Conversation
|
Sorry I was fighting with the trailing comma, because I've seen in the guidelines there shouldn't be one (but I guess it just applies strictly to JSON files), and I didn't know/understood right away that the linter would add it automatically. I'm so sorry, it just messes up the history of the PR and triggered builds for nothing. |
frontend/src/ts/pages/friends.ts
Outdated
| if (entry.raw) { | ||
| details.push(`${result.raw} raw`); | ||
| } | ||
| if (entry.consistency) { |
There was a problem hiding this comment.
This will not show consistency when it's 0%. Let's use a more specific if statement:
if (entry.consistency != null)
There was a problem hiding this comment.
The linter doesn't let me use !=, so I did a check on 0 instead
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
5 participants
Description
Show less details for legacy PBs in the friendlist.
Checks